Update dependencies #481

kinow · 2020-08-19T02:31:45Z

This is a small change with no associated Issue.

I used ncu to get a list of dependencies that had updates available. Then went through these dependencies individually, updating each one and checking if the build was working OK.

vuetify was not updated as it is being updated in #466.

Updating eslint-config-vuetify resulted in some weird errors in yarn install:

error An unexpected error occurred: "could not find a copy of eslint to link in /home/kinow/Development/python/workspace/cylc-ui/node_modules/eslint-config-vuetify/node_modules".

So I reverted it and will take care of that dependency later (it is a dev dependency).

Requirements check-list

I have read CONTRIBUTING.md and added my name as a Code Contributor.
Contains logically grouped changes (else tidy your branch by rebase).
Does not contain off-topic changes (use other PRs for other changes).
Already covered by existing tests.
Appropriate change log entry included.
No documentation update required.

kinow · 2020-08-19T02:38:56Z

Huh, more dependencies missing now. Some core-js, eslint-plugin-import... :sigh:

Always an adventure updating JS dependencies 🤓

kinow · 2020-08-19T02:46:09Z

package.json

+    "@lumino/datagrid": "^0.12.0",
+    "@lumino/default-theme": "^0.4.4",
+    "@lumino/widgets": "^1.13.4",
+    "apollo-boost": "^0.4.9",


When we first added Apollo, we used apollo-boost. Which is just the apollo-client wrapped by several utility functions, and features like caching.

Later, after realizing we didn't need any of the features in apollo-boost, I started moving the WorkflowService to use just ApolloClient. That also became necessary as we started customizing the client for the WebSockets.

I will have to confirm, but I believe I have finished getting rid of apollo-boost, but added the dependencies for the non-apollo-boost setting in the devDependencies.

If so, we can remove the Apollo dependencies from devDependencies, move them up here, and maybe reduce our list of dependencies, as ApolloBoost includes more code/dependencies.

kinow · 2020-08-19T02:55:48Z

package.json

-    "cytoscape-expand-collapse": "^3.1.2",
-    "cytoscape-node-html-label": "^1.1.5",
+    "cytoscape-expand-collapse": "^4.0.0",
+    "cytoscape-node-html-label": "^1.2.0",


I'm updating the Graph dependencies, assuming they won't require us to change anything in the Graph component or view 👍 if they demand further work, I will remove these changes to simplify the PR, since we may choose a different library for handling Graphs in Cylc UI.

I think we may want to remove the graph view next release, pending @oliver-sanders massive re-do. Probably not good to have a barely-usable POC graph view with wrong look-and-feel alongside our nice (and now performant, post deltas) tree view. (n-distance windows might save graph view performance, but still have the other problems...).

At least removing dependencies and code is easier. Just need to remember to remove not only cytoscape- dependencies, but also the tippy I think. Would be nice if there were dependency groups in NPM, or if at least we could add comments to package.json (JSON limitation)

kinow · 2020-08-19T03:21:24Z

eslint-plugin-import missing after updating dependencies. Added with yarn add -D eslint-plugin-import.

kinow · 2020-08-19T03:22:24Z

Now vue-markdown is giving me issues after updating the other dependencies. Related to this issue: miaolz123/vue-markdown#18

Looks like vue-markdown require us to include another dependency now: yarn add babel-runtime --save 🤷‍♂️

kinow · 2020-08-19T03:24:36Z

I can now build it with yarn run build:watch, but one warning in the ./srv/views/Mutations.vue:

"export 'introspectionQuery' was not found in 'graphql'

🤔

codecov-commenter · 2020-08-19T03:27:06Z

Codecov Report

Merging #481 into master will decrease coverage by 8.46%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #481      +/-   ##
==========================================
- Coverage   69.90%   61.43%   -8.47%     
==========================================
  Files          58       42      -16     
  Lines        1266      918     -348     
  Branches       78       42      -36     
==========================================
- Hits          885      564     -321     
+ Misses        361      341      -20     
+ Partials       20       13       -7

Flag	Coverage Δ
#e2e	`?`
#unittests	`61.43% <0.00%> (-0.44%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/views/Mutations.vue	`37.87% <0.00%> (-4.55%)`	⬇️
src/mixins/index.js	`0.00% <0.00%> (-100.00%)`	⬇️
src/mixins/treeview.js	`0.00% <0.00%> (-100.00%)`	⬇️
src/router/index.js	`0.00% <0.00%> (-96.67%)`	⬇️
src/main.js	`0.00% <0.00%> (-91.67%)`	⬇️
src/components/cylc/workflow/lumino-widget.js	`0.00% <0.00%> (-84.22%)`	⬇️
src/components/cylc/workflow/Lumino.vue	`30.00% <0.00%> (-66.67%)`	⬇️
src/components/cylc/graph/index.js	`0.00% <0.00%> (-42.86%)`	⬇️
src/store/workflows.module.js	`63.63% <0.00%> (-36.37%)`	⬇️
src/components/cylc/tree/TreeItem.vue	`69.23% <0.00%> (-26.93%)`	⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92db6fd...d88bed4. Read the comment docs.

kinow · 2020-08-19T03:31:29Z

I can now build it with yarn run build:watch, but one warning in the ./srv/views/Mutations.vue:
"export 'introspectionQuery' was not found in 'graphql'
thinking

Tree view OK.

Graph view OK.

Mutations view is now broken. Looking into that.

From the warning message, it looks like the GraphQL library stopped exporting introspectionQuery?

kinow · 2020-08-19T03:33:03Z

package.json

-    "sinon": "^7.5.0",
-    "standard": "^14.3.1",
-    "subscriptions-transport-ws": "^0.9.16",
+    "lodash": "^4.17.20",


I think lodash is actually a runtime dependency. Maybe it's working now if another dependency is loading it (the Apollo libraries do). But this needs to be moved to the dependencies and removed from the devDependencies.

kinow · 2020-08-19T03:51:24Z

Fixed build, no more warnings, but for some reason the Mutations are not loading now.

The view /#/mutations works with no issues however. So might be something with the wrappers, or the Lumino tab that affects only the mutations.

kinow · 2020-08-19T04:45:58Z

The Mutations view was wrapped in a skeleton loader that had a isLoading flag always set to true. Funny that I think it was supposed to happen on master too.

Anyhoo, have modified it to leave the loading to the Mutations view, as that view is using another flag for whether it is loading or not.

For tomorrow:

move lodash to dependencies, and remove from dev dependencies
move apollo dependencies to dependencies, and remove them from dev dependencies
another manual test to make sure there are no regressions
change log

Then it should be ready for review

oliver-sanders · 2020-08-19T08:51:09Z

Looks good to me.

kinow · 2020-08-19T22:34:13Z

PR ready for review.

The master branch produces 8MB of assets.

This branch produces 7.9MB.

Most likely related to updates in libraries that have either reduced their code size, or did changes that permit better tree-shaking. Could also be related to the removal of ApolloBoost, replaced by the fine-grained Apollo libraries (ApolloBoost just wraps several libraries into a library for convenience, plus some constructors to get clients with cache, etc).

Bruno

kinow · 2020-08-19T22:36:17Z

src/components/cylc/workflow/index.js

-      <component
-        is="VSkeletonLoader"
-        :ref="widgetId"
-        :loading="isLoading"


This is always true if you have nothing in the UI but the mutation. With Graph and Tree views, the subscriptions when started can change the view's isLoading state.

But the mutation widget doesn't trigger any subscription.

So instead we simply add a Mutation view. The view has a loading state, and displays "Loading..." immediately when loaded. Furthermore, with work to add mutations in the right places, this view might be hidden or removed I guess.

kinow · 2020-08-19T22:37:33Z

src/views/Mutations.vue

@@ -39,7 +39,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.

 <script>
 import gql from 'graphql-tag'
-import { introspectionQuery, print } from 'graphql'
+import { getIntrospectionQuery as getGraphQLIntrospectionQuery, print } from 'graphql'


Changed in GraphQL 15. Luckily they didn't remove the functionality.

Note that we already have a function in this module called getIntrospectionQuery, by coincidence. So if we imported like this, we could end up with weird build issues (e.g. recursively calling itself instead of calling the function from the graphql module). So I've renamed the import 👍

kinow · 2020-08-19T23:20:55Z

Rebased

oliver-sanders

Tested in offline mode, graph broken but that might be expected.

I'm getting a lot of "incorrect peer dependency" warnings during installation (though I got some of these before):

warning "@lumino/datagrid > @lumino/[email protected]" has unmet peer dependency "[email protected]".
warning "apollo-client > [email protected]" has incorrect peer dependency "graphql@^0.11.3 || ^0.12.3 || ^0.13.0 || ^14.0.0".
warning "apollo-link > [email protected]" has incorrect peer dependency "graphql@^0.11.0 || ^0.12.0 || ^0.13.0 || ^14.0.0".
warning " > [email protected]" has unmet peer dependency "prop-types@>=15.5.0".
warning " > @babel/[email protected]" has unmet peer dependency "@babel/core@^7.0.0-0".
warning "@babel/plugin-proposal-class-properties > @babel/[email protected]" has unmet peer dependency "@babel/core@^7.0.0".
warning " > @cypress/[email protected]" has unmet peer dependency "cypress@*".
warning " > @cypress/[email protected]" has unmet peer dependency "@babel/core@^7.0.1".
warning " > @cypress/[email protected]" has unmet peer dependency "@babel/preset-env@^7.0.0".
warning " > @cypress/[email protected]" has unmet peer dependency "babel-loader@^8.0.2".
warning "@vue/cli-plugin-eslint > [email protected]" has incorrect peer dependency "eslint@>=1.6.0 <7.0.0".
warning " > [email protected]" has unmet peer dependency "eslint-plugin-promise@>=4.2.1".
warning " > [email protected]" has incorrect peer dependency "eslint@^6.7.2".
warning " > [email protected]" has incorrect peer dependency "eslint@^5.0.0 || ^6.0.0".

kinow · 2020-08-20T08:48:26Z

Tested in offline mode, graph broken but that might be expected.

Yup, the graph never worked in offline mode. That's because the mocked WorkflowService only returns the tree data.

I'm getting a lot of "incorrect peer dependency" warnings during installation (though I got some of these before):

Yup, caused by the move to Graphql 15. Most of our dependencies have some ranges like graphql 13 | 14, or something similar to that. But apparently everything that we use is still working.

But if you prefer to reduce the risk by moving it down to 14 I can downgrade it too (takes just a few minutes as I'm deleting the node_modules when updating just to make sure I don't have any vestige of previous installations)

oliver-sanders

Yup, caused by the move to Graphql 15.

Ok, if you've got a handle on what's causing it, looks like the warnings are harmless.

I used `ncu` to get a list of dependencies that had updates available. Then went through these dependencies individually, updating each one and checking if the build was working OK. `vuetify` was not updated as it is being updated in cylc#466. Updating `eslint-config-vuetify` resulted in some weird errors in `yarn install`: error An unexpected error occurred: "could not find a copy of eslint to link in /home/kinow/Development/python/workspace/cylc-ui/node_modules/eslint-config-vuetify/node_modules". So I reverted it and will take care of that dependency later (it is a dev dependency).

…d after updating dependencies.

See more on their issue at miaolz123/vue-markdown#18

…so is Axios (user-profile service)

kinow · 2020-08-20T09:11:03Z

Rebased

kinow self-assigned this Aug 19, 2020

kinow added this to the 0.3 milestone Aug 19, 2020

kinow commented Aug 19, 2020

View reviewed changes

kinow marked this pull request as ready for review August 19, 2020 22:32

kinow requested review from hjoliver and oliver-sanders August 19, 2020 22:34

kinow commented Aug 19, 2020

View reviewed changes

kinow force-pushed the update-dependencies branch from ede7844 to 307a21a Compare August 19, 2020 23:18

oliver-sanders reviewed Aug 20, 2020

View reviewed changes

oliver-sanders approved these changes Aug 20, 2020

View reviewed changes

kinow added 5 commits August 20, 2020 20:54

Install eslint-plugin-import reported as missing when tried to buil…

9a8436c

…d after updating dependencies.

Add babel-runtime for vue-markdown

7221e7a

See more on their issue at miaolz123/vue-markdown#18

Use getIntrospectionQuery now instead of introspectionQuery.

fabcdcb

lodash is not only for development

21ead91

kinow added 2 commits August 20, 2020 21:01

Apollo Boost is not necessary. Apollo libraries are for runtime, and …

54fab8c

…so is Axios (user-profile service)

Add changelog

04d701a

kinow force-pushed the update-dependencies branch from 307a21a to 04d701a Compare August 20, 2020 09:01

Add (now) missing @vue/babel-preset-app for development dependencies

d88bed4

kinow mentioned this pull request Aug 20, 2020

Update to new apollo-client 3.1.1 #473

Closed

hjoliver approved these changes Aug 25, 2020

View reviewed changes

hjoliver merged commit 292d44e into cylc:master Aug 25, 2020

kinow deleted the update-dependencies branch August 25, 2020 09:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update dependencies #481

Update dependencies #481

kinow commented Aug 19, 2020 •

edited

Loading

kinow commented Aug 19, 2020

kinow Aug 19, 2020

kinow Aug 19, 2020

hjoliver Aug 19, 2020 •

edited

Loading

kinow Aug 19, 2020

kinow commented Aug 19, 2020

kinow commented Aug 19, 2020

kinow commented Aug 19, 2020

codecov-commenter commented Aug 19, 2020 •

edited

Loading

kinow commented Aug 19, 2020

kinow Aug 19, 2020

kinow commented Aug 19, 2020 •

edited

Loading

kinow commented Aug 19, 2020 •

edited

Loading

oliver-sanders commented Aug 19, 2020

kinow commented Aug 19, 2020

kinow Aug 19, 2020

kinow Aug 19, 2020

kinow commented Aug 19, 2020

oliver-sanders left a comment •

edited

Loading

kinow commented Aug 20, 2020

oliver-sanders left a comment

kinow commented Aug 20, 2020

Update dependencies #481

Update dependencies #481

Conversation

kinow commented Aug 19, 2020 • edited Loading

kinow commented Aug 19, 2020

kinow Aug 19, 2020

Choose a reason for hiding this comment

kinow Aug 19, 2020

Choose a reason for hiding this comment

hjoliver Aug 19, 2020 • edited Loading

Choose a reason for hiding this comment

kinow Aug 19, 2020

Choose a reason for hiding this comment

kinow commented Aug 19, 2020

kinow commented Aug 19, 2020

kinow commented Aug 19, 2020

codecov-commenter commented Aug 19, 2020 • edited Loading

Codecov Report

kinow commented Aug 19, 2020

kinow Aug 19, 2020

Choose a reason for hiding this comment

kinow commented Aug 19, 2020 • edited Loading

kinow commented Aug 19, 2020 • edited Loading

oliver-sanders commented Aug 19, 2020

kinow commented Aug 19, 2020

kinow Aug 19, 2020

Choose a reason for hiding this comment

kinow Aug 19, 2020

Choose a reason for hiding this comment

kinow commented Aug 19, 2020

oliver-sanders left a comment • edited Loading

Choose a reason for hiding this comment

kinow commented Aug 20, 2020

oliver-sanders left a comment

Choose a reason for hiding this comment

kinow commented Aug 20, 2020

kinow commented Aug 19, 2020 •

edited

Loading

hjoliver Aug 19, 2020 •

edited

Loading

codecov-commenter commented Aug 19, 2020 •

edited

Loading

kinow commented Aug 19, 2020 •

edited

Loading

kinow commented Aug 19, 2020 •

edited

Loading

oliver-sanders left a comment •

edited

Loading